From 33b6c8a6413a8d9bcf8afd4dfd83030a30b67e8b Mon Sep 17 00:00:00 2001 From: Hanspeter Portner Date: Fri, 24 Nov 2023 22:20:02 +0100 Subject: [PATCH] Fix dead code analyzer warnings --- meson_options.txt | 2 +- src/forge.c | 26 +++++++++++++------------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index a31a3dc..516abff 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -6,4 +6,4 @@ option('build-tests', value : true, yield : true) -option('version', type : 'string', value : '0.1.183') +option('version', type : 'string', value : '0.1.187') diff --git a/src/forge.c b/src/forge.c index 4fdd270..6d0309f 100644 --- a/src/forge.c +++ b/src/forge.c @@ -16,7 +16,7 @@ lv2_osc_forge_chunk(LV2_Atom_Forge *forge, LV2_URID type, { LV2_Atom_Forge_Ref ref; - if( (ref = lv2_atom_forge_atom(forge, size, type)) + if( lv2_atom_forge_atom(forge, size, type) && (ref = lv2_atom_forge_raw(forge, buf, size)) ) { lv2_atom_forge_pad(forge, size); @@ -64,10 +64,10 @@ lv2_osc_forge_timetag(LV2_Atom_Forge *forge, LV2_OSC_URID *osc_urid, LV2_Atom_Forge_Frame frame; LV2_Atom_Forge_Ref ref; - if( (ref = lv2_atom_forge_object(forge, &frame, 0, osc_urid->OSC_Timetag)) - && (ref = lv2_atom_forge_key(forge, osc_urid->OSC_timetagIntegral)) - && (ref = lv2_atom_forge_long(forge, timetag->integral)) - && (ref = lv2_atom_forge_key(forge, osc_urid->OSC_timetagFraction)) + if( lv2_atom_forge_object(forge, &frame, 0, osc_urid->OSC_Timetag) + && lv2_atom_forge_key(forge, osc_urid->OSC_timetagIntegral) + && lv2_atom_forge_long(forge, timetag->integral) + && lv2_atom_forge_key(forge, osc_urid->OSC_timetagFraction) && (ref = lv2_atom_forge_long(forge, timetag->fraction)) ) { lv2_atom_forge_pop(forge, &frame); @@ -83,10 +83,10 @@ lv2_osc_forge_bundle_head(LV2_Atom_Forge* forge, LV2_OSC_URID *osc_urid, { LV2_Atom_Forge_Ref ref; - if( (ref = lv2_atom_forge_object(forge, &frame[0], 0, osc_urid->OSC_Bundle)) - && (ref = lv2_atom_forge_key(forge, osc_urid->OSC_bundleTimetag)) - && (ref = lv2_osc_forge_timetag(forge, osc_urid, timetag)) - && (ref = lv2_atom_forge_key(forge, osc_urid->OSC_bundleItems)) + if( lv2_atom_forge_object(forge, &frame[0], 0, osc_urid->OSC_Bundle) + && lv2_atom_forge_key(forge, osc_urid->OSC_bundleTimetag) + && lv2_osc_forge_timetag(forge, osc_urid, timetag) + && lv2_atom_forge_key(forge, osc_urid->OSC_bundleItems) && (ref = lv2_atom_forge_tuple(forge, &frame[1])) ) { return ref; @@ -105,10 +105,10 @@ lv2_osc_forge_message_head(LV2_Atom_Forge *forge, LV2_OSC_URID *osc_urid, assert(path); LV2_Atom_Forge_Ref ref; - if( (ref = lv2_atom_forge_object(forge, &frame[0], 0, osc_urid->OSC_Message)) - && (ref = lv2_atom_forge_key(forge, osc_urid->OSC_messagePath)) - && (ref = lv2_atom_forge_string(forge, path, strlen(path))) - && (ref = lv2_atom_forge_key(forge, osc_urid->OSC_messageArguments)) + if( lv2_atom_forge_object(forge, &frame[0], 0, osc_urid->OSC_Message) + && lv2_atom_forge_key(forge, osc_urid->OSC_messagePath) + && lv2_atom_forge_string(forge, path, strlen(path)) + && lv2_atom_forge_key(forge, osc_urid->OSC_messageArguments) && (ref = lv2_atom_forge_tuple(forge, &frame[1])) ) { return ref; -- 2.38.5